Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add storage version migrator #3168

Merged
merged 7 commits into from
May 22, 2020
Merged

add storage version migrator #3168

merged 7 commits into from
May 22, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 19, 2020 •
edited
Loading

Addresses #3095

Proposed Changes

  • Add a Job that upgrades the storage version for the following components:
          - "parallels.flows.knative.dev"
          - "sequences.flows.knative.dev"
          - "eventtypes.eventing.knative.dev"
          - "triggers.eventing.knative.dev"
          - "channels.messaging.knative.dev"
          - "inmemorychannels.messaging.knative.dev"
          - "subscriptions.messaging.knative.dev"

Release Note

Action Required: You need to run the storage migration tool after the upgrade.
- 🧽 Update or clean up current behavior
Add a tool for migrating storage version from v1alpha1 to v1beta1 for the following resources:
          - "parallels.flows.knative.dev"
          - "sequences.flows.knative.dev"
          - "eventtypes.eventing.knative.dev"
          - "triggers.eventing.knative.dev"
          - "channels.messaging.knative.dev"
          - "inmemorychannels.messaging.knative.dev"
          - "subscriptions.messaging.knative.dev"

Docs

knative/docs#2484

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2020
@dprotaso
Copy link
Member

dprotaso commented May 20, 2020 •
edited
Loading

I'm assuming you're flipping the storageVersion in your CRD definitions in 0.15.0?

It might also be worth including upgrade tests: knative/serving#7620

@vaikas
Copy link
Contributor Author

vaikas commented May 21, 2020

@dprotaso yeppers, done here:
#3169
I'm working on e2e tests also, didn't see those as part of your issue (or missed) :)

grantr
grantr approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Holding for question about postinstall dummy.go. Feel free to unhold if no changes are needed.

config/post-install/v0.15.0/dummy.go

// Package postinstall is a placeholder that allows us to pull in config files
// via go mod vendor.
package postinstall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this file is necessary. Will these config files be used as a dependency in other modules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If for example, we want operator to import these, if there's no go files, we can't import them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, see:
#3098

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor Author

vaikas commented May 22, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@vaikas
Copy link
Contributor Author

vaikas commented May 22, 2020

/test pull-knative-eventing-integration-tests

@vaikas
Copy link
Contributor Author

vaikas commented May 22, 2020

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 45da935 into knative:master May 22, 2020
@vaikas vaikas deleted the issue-3095 branch May 22, 2020 19:54
@vaikas vaikas mentioned this pull request Sep 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@mattmoor mattmoor mattmoor left review comments

@grantr grantr grantr approved these changes

@aslom aslom Awaiting requested review from aslom

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vaikas @dprotaso @knative-prow-robot @grantr @matzew @mattmoor @googlebot